[PATCH 1/7] checkpatch.pl: Make common.h check boarder
Simon Glass
sjg at chromium.org
Fri Oct 13 17:49:13 CEST 2023
Hi Tom,
On Fri, 13 Oct 2023 at 08:16, Tom Rini <trini at konsulko.com> wrote:
>
> On Fri, Oct 13, 2023 at 08:15:00AM -0700, Simon Glass wrote:
> > On Thu, 12 Oct 2023 at 16:04, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > At this point in time we should not add common.h to any new files, so
> > > make checkpatch.pl complain.
> > >
> > > Signed-off-by: Tom Rini <trini at konsulko.com>
> > > ---
> > > Cc: Simon Glass <sjg at chromium.org>
> > >
> > > This causes a bunch of patman tests, for checkpatch, to now fail and I
> > > don't really understand why, at all. And that was before I added a test
> > > for the new error, which I had hoped would clear up the problem.
> > > ---
> > > scripts/checkpatch.pl | 8 +++++++-
> > > tools/patman/test_checkpatch.py | 7 ++++++-
> > > 2 files changed, 13 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
>
> It can't be reviewed, as I can't actually apply it, as it causes CI to
> fail as patman tests now fail, and I don't know why.
Well the code looks OK to me. I will take a look.
Regards,
Simon
More information about the U-Boot
mailing list