[PATCH 4/7] m68k: Remove common.h usage

Angelo Dureghello angelo at kernel-space.org
Fri Oct 13 23:40:34 CEST 2023


Hi Tom,

sorry, applied all now, it works, i can boot properly.

Thanks.

Acked-by: Angelo Dureghello <angelo at kernel-space.org>

On 13/10/23 10:55 PM, Tom Rini wrote:
> On Fri, Oct 13, 2023 at 10:53:04PM +0200, Angelo Dureghello wrote:
>> Hi Tom,
>>
>>
>> On 13/10/23 1:03 AM, Tom Rini wrote:
>>> We can remove common.h from most cases of the code here, and only a few
>>> places need an additional header instead.
>>>
>>> Signed-off-by: Tom Rini <trini at konsulko.com>
>>> ---
>>> Cc: Angelo Dureghello <angelo at kernel-space.org>
>>> ---
>>>    arch/m68k/cpu/mcf523x/cpu.c         | 1 -
>>>    arch/m68k/cpu/mcf523x/cpu_init.c    | 1 -
>>>    arch/m68k/cpu/mcf523x/interrupts.c  | 1 -
>>>    arch/m68k/cpu/mcf523x/speed.c       | 1 -
>>>    arch/m68k/cpu/mcf52x2/cpu.c         | 1 -
>>>    arch/m68k/cpu/mcf52x2/cpu_init.c    | 3 +--
>>>    arch/m68k/cpu/mcf52x2/interrupts.c  | 1 -
>>>    arch/m68k/cpu/mcf52x2/speed.c       | 1 -
>>>    arch/m68k/cpu/mcf530x/cpu.c         | 1 -
>>>    arch/m68k/cpu/mcf530x/cpu_init.c    | 1 -
>>>    arch/m68k/cpu/mcf530x/interrupts.c  | 1 -
>>>    arch/m68k/cpu/mcf530x/speed.c       | 1 -
>>>    arch/m68k/cpu/mcf532x/cpu.c         | 1 -
>>>    arch/m68k/cpu/mcf532x/cpu_init.c    | 1 -
>>>    arch/m68k/cpu/mcf532x/interrupts.c  | 1 -
>>>    arch/m68k/cpu/mcf532x/speed.c       | 1 -
>>>    arch/m68k/cpu/mcf5445x/cpu.c        | 1 -
>>>    arch/m68k/cpu/mcf5445x/cpu_init.c   | 1 -
>>>    arch/m68k/cpu/mcf5445x/dspi.c       | 1 -
>>>    arch/m68k/cpu/mcf5445x/interrupts.c | 1 -
>>>    arch/m68k/cpu/mcf5445x/speed.c      | 1 -
>>>    arch/m68k/cpu/mcf5445x/start.S      | 1 -
>>>    arch/m68k/include/asm/immap.h       | 1 +
>>>    arch/m68k/include/asm/immap_520x.h  | 1 +
>>>    arch/m68k/include/asm/immap_5235.h  | 1 +
>>>    arch/m68k/include/asm/immap_5272.h  | 1 +
>>>    arch/m68k/include/asm/immap_5275.h  | 1 +
>>>    arch/m68k/include/asm/immap_5282.h  | 1 +
>>>    arch/m68k/include/asm/immap_5301x.h | 1 +
>>>    arch/m68k/include/asm/immap_5307.h  | 2 ++
>>>    arch/m68k/include/asm/immap_5329.h  | 1 +
>>>    arch/m68k/include/asm/immap_5441x.h | 1 +
>>>    arch/m68k/lib/bdinfo.c              | 3 ++-
>>>    arch/m68k/lib/bootm.c               | 1 -
>>>    arch/m68k/lib/cache.c               | 2 +-
>>>    arch/m68k/lib/fec.c                 | 2 +-
>>>    arch/m68k/lib/interrupts.c          | 2 +-
>>>    arch/m68k/lib/time.c                | 1 -
>>>    arch/m68k/lib/traps.c               | 1 -
>>>    39 files changed, 17 insertions(+), 30 deletions(-)
>>>
>>
>> building for mcf5307 i get this error
>>
>> In file included from arch/m68k/lib/bootm.c:7:
>> include/bootstage.h:225:1: error: unknown type name 'ulong'; did you mean
>> 'long'?
>>    225 | ulong timer_get_boot_us(void);
>>        | ^~~~~
> 
> Did you apply the whole series?  The first few patches fix some global
> issues.
> 

-- 
Angelo Dureghello
w: www.kernel-space.org
e: angelo at kernel-space.org


More information about the U-Boot mailing list