[PATCH] binman: bintool: Change make target arg type from string to list
Simon Glass
sjg at chromium.org
Sat Oct 14 00:00:39 CEST 2023
On Wed, 4 Oct 2023 at 02:56, <lukas.funke-oss at weidmueller.com> wrote:
>
> From: Lukas Funke <lukas.funke at weidmueller.com>
>
> The argument type of `build_from_git` was changed from string to list
> in d71e7116997f14097735f04cc7847f0a68dbc485.
>
> This commit adapts the argument type of all bintools using this
> function.
>
> Signed-off-by: Lukas Funke <lukas.funke at weidmueller.com>
>
> ---
>
> tools/binman/btool/bootgen.py | 2 +-
> tools/binman/btool/fiptool.py | 2 +-
> tools/binman/btool/futility.py | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Simon Glass <sjg at chromium.org>
Tested-by: Simon Glass <sjg at chromium.org>
Thank you.
Can you please resolve the test-coverage issue, too? It is the one
line in the whole of binman with no coverage. If it is not needed, we
can delete the line, perhaps?
tools/binman/etype/xilinx_bootgen.py 72 1 99%
The offending line is 216:
data = tools.read_file(bootbin_fname)
Regards,
Simon
Applied to u-boot-dm, thanks!
More information about the U-Boot
mailing list