[PATCH v2 12/19] serial: sh: Add RZ/G2L SCIF support

[Marek Vasut]

On 10/15/23 19:59, Paul Barker wrote:
> On Sat, Oct 14, 2023 at 09:53:53PM +0200, Marek Vasut wrote:
>> On 10/9/23 18:46, Paul Barker wrote:
>>> Extend the existing driver to support the SCIF serial ports on the
>>> Renesas RZ/G2L (R9A07G044) SoC. This also requires us to ensure that the
>>> relevant reset signal is de-asserted before we try to talk to the SCIF
>>> module.
>>>
>>> Signed-off-by: Paul Barker <paul.barker.ct at bp.renesas.com>
>>> Reviewed-by: Biju Das <biju.das.jz at bp.renesas.com>
>>> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj at bp.renesas.com>
>>> ---
>>> v1->v2:
>>>     * Moved handle_error() changes out to a separate patch earlier in the
>>>       series.
>>>     * Unconditionally de-assert the module reset during probe.
>>>
>>>    arch/arm/mach-rmobile/Kconfig |  1 +
>>>    drivers/serial/serial_sh.c    | 17 +++++++++++++++++
>>>    drivers/serial/serial_sh.h    | 19 ++++++++++++++++++-
>>>    3 files changed, 36 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/mach-rmobile/Kconfig b/arch/arm/mach-rmobile/Kconfig
>>> index c30ff2caad17..c421181c89cf 100644
>>> --- a/arch/arm/mach-rmobile/Kconfig
>>> +++ b/arch/arm/mach-rmobile/Kconfig
>>> @@ -77,6 +77,7 @@ config RZG2L
>>>    	imply MULTI_DTB_FIT_USER_DEFINED_AREA
>>>    	imply PINCTRL_RZG2L
>>>    	imply RENESAS_SDHI
>>> +	imply SCIF_CONSOLE
>>>    	imply SYS_MALLOC_F
>>>    	help
>>>    	  Enable support for the Renesas RZ/G2L family of SoCs. Currently
>>> diff --git a/drivers/serial/serial_sh.c b/drivers/serial/serial_sh.c
>>> index 2b650d458e71..6ea8da34d434 100644
>>> --- a/drivers/serial/serial_sh.c
>>> +++ b/drivers/serial/serial_sh.c
>>> @@ -17,6 +17,8 @@
>>>    #include <linux/compiler.h>
>>>    #include <dm/platform_data/serial_sh.h>
>>>    #include <linux/delay.h>
>>> +#include <dm/device_compat.h>
>>> +#include <reset.h>
>>
>> Please keep the list sorted.
> 
> The existing include list isn't sorted, so in v3 I'll add a patch to
> sort the list first. Then these two can be added in the right places.

Much appreciated, thanks !