[PATCH 1/2] command.h: Add a U_BOOT_LONGHELP macro

[Tom Rini]

On Sun, Oct 15, 2023 at 08:39:44AM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On Sat, 7 Oct 2023 at 13:13, Tom Rini <trini at konsulko.com> wrote:
> >
> > In order to be able to discard unused long help texts without further
> > linker lists, add a macro for defining the long help messages which uses
> > __maybe_unused.  This allows us to discard them as unreferenced as part
> > of the link.
> >
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > ---
> >  include/command.h | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/include/command.h b/include/command.h
> > index 34ea989b39b4..a836ea795ab6 100644
> > --- a/include/command.h
> > +++ b/include/command.h
> > @@ -322,6 +322,9 @@ int cmd_source_script(ulong addr, const char *fit_uname, const char *confname);
> >  # define _CMD_HELP(x)
> >  #endif
> >
> > +#define U_BOOT_LONGHELP(_cmdname, text)                                        \
> > +       static __maybe_unused const char _cmdname##_help_text[] = text;
> 
> I just noticed this...do you really want the ; at the end? The only
> purpose I can see is if you want the macro to compile to nothing.
> Otherwise it is more normal to put it on the invocations, isn't it?

I'll drop that when I apply it.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231016/8049bccc/attachment.sig>