[PATCH v3 02/32] bootstd: Correct dependencies on CMDLINE

[Simon Glass]

Hi Tom,

On Tue, 17 Oct 2023 at 07:32, Tom Rini <trini at konsulko.com> wrote:
>
> On Mon, Oct 16, 2023 at 04:27:53PM -0600, Simon Glass wrote:
>
> > With recent changes over the last few years in boot/Kconfig it is
> > no-longer possible to disable CMDLINE. It results in various link
> > errors because some options which require CMDLINE are enabled
> > regardless of whether it is available.
> >
> > Add the necessary conditions to fix this.
> >
> > Note that it would be better to have all commands depend on CMDLINE,
> > but that is extremely difficult at present, since some functions use
> > CMD_xxx to enable feature xxx. For example networking and environment
> > have a number of problems to tease apart.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
>
> Since you later rework things to tease apart most, if not all of this,
> please split out the patches which tease things apart in to their own
> series so that the rest of this becomes reviewable and also reasonable
> looking.

At this point I fear I have lost track of things, since there is just
too much going on. Just in this version I have dealt with:

- some EFI stuff (which needs tweaking)
- teasing apart the CLI handling (which apparently doesn't go far enough?)

Before this version I already looked at environment (which you say
doesn't go far enough, and fair enough, but please review the code as
sent, not what you wish it was).

Perhaps you could apply whatever seems reasonable and then I can take
another look? Or suggest some small changes that would allow progress
to be made.

But do note that supporting booting without CONFIG_CMDLINE is a large
effort, the subject of 5-10 series, perhaps more. It is not my
intention to undertake that in this series, or before this series
lands

The problem, also, is that without this series, it isn't possible to
start that work. With this series, one can look at what code is
missing and find a way to call boot functions (for example) bypassing
the command line. Once you get it booting you are good. Without this
series, you don't even know where to look, since calls to the command
line happen silently.

So I think this series is a big step forward and urge another look, please.

Regards,
Simon