[PATCH v3 04/32] cmd: Add a few more dependencies on CMDLINE

[Simon Glass]

Hi Tom,

On Tue, 17 Oct 2023 at 07:32, Tom Rini <trini at konsulko.com> wrote:
>
> On Mon, Oct 16, 2023 at 04:27:55PM -0600, Simon Glass wrote:
>
> > Add this to some more commands to avoid build errors with sandbox.
> >
> > Note that this is a temporary solution to expose more problems. A later
> > patch puts these behind an 'if CMDLINE'
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
>
> We're doing a bunch of churn here that I'd rather just get done at once,
> make the current #27 which guards all commands with if CMDLINE happen
> earlier in the series instead.

Yes I did consider this when reviewing this patch for v3, but got
build-bisect failures. I cannot move #27 earlier, since all the builds
fail. Allowing #27 to pass is the point of this series, in fact.

If we can make progress on the thrust of this series then I will see
if I can somehow reorder some other patches to drop this patch, or
move it later, or cut it down, or something else...

I also don't agree with 'bunch of'. This is 6 lines, which enables
another 20 patches which clean everything up. Are there other patches
with churn?

Regards,
Simon