[PATCH v3 14/32] bootm: Allow building when cleanup functions are missing

[Tom Rini]

On Tue, Oct 17, 2023 at 09:31:04PM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On Tue, 17 Oct 2023 at 08:02, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Mon, Oct 16, 2023 at 04:28:05PM -0600, Simon Glass wrote:
> >
> > > There are two cleanup functions needed during boot which depend on
> > > CMD_BOOTM: bootm_disable_interrupts() and board_quiesce_devices()
> > >
> > > Provide static inline versions of these for when commands are not
> > > enabled.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> >
> > NAK, these functions need to be available to boot the OS, regardless of
> > command line existing or not.  Unwind things in the other direction
> > please.
> 
> That won't be a successful strategy. See my other reply on this. I
> have had this idea since 2016 and have looked at it every now and
> then. With bootstd it makes more sense since we actually have a
> framework to boot without the command line. This series enables such
> work, but cannot include it.

I don't understand.  The "cleanup" functions here are to ensure that any
devices that we've touched are in the state the OS needs them to be.
It's not "we ran a command", it's "we loaded something off of USB (or
network or MMC or ..)" and so we must have those called.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231018/fe81972d/attachment.sig>