[PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

[Heinrich Schuchardt]

On 10/17/23 16:09, Tom Rini wrote:
> On Mon, Oct 16, 2023 at 04:28:13PM -0600, Simon Glass wrote:
>
>> Since efi_device_path.c calls eth_get_dev() and assumes that Ethernet is
>> available, add it as an explicit dependency.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>> (no changes since v2)
>>
>> Changes in v2:
>> - Add new patch to update EFI_LOADER to depend on DM_ETH
>>
>>   lib/efi_loader/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
>> index 13cad6342c36..fca4b3eef270 100644
>> --- a/lib/efi_loader/Kconfig
>> +++ b/lib/efi_loader/Kconfig
>> @@ -11,6 +11,7 @@ config EFI_LOADER
>>   	# We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
>>   	depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
>>   	depends on BLK
>> +	depends on DM_ETH
>>   	depends on !EFI_APP
>>   	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
>>   	select CHARSET
>
> Does this work for you Heinrich, or do you want to clarify the
> dependencies (and re-organize the code as needed) around networking?
>

We should be able to boot via EFI on devices without U-Boot network support.

We already use IS_ENABLED(CONFIG_NETDEVICES) to avoid invoking
eth_get_dev() if there is no network. CONFIG_NETDEVICES=y selects
CONFIG_DM_ETH.

Why is this not sufficient?
Is there a configuration that does not build?

Best regards

Heinrich