[PATCH v2] drivers: firmware: Handle error case in the zynqmp_pm_feature

[Michal Simek]

On 10/11/23 04:56, Venkatesh Yadav Abbarapu wrote:
> Unhandled error coming from xilinx_pm_request() but return
> value is not read back that's why getting sparse warning
> as below:
> warning: variable 'ret' set but not used [-Wunused-but-set-variable].
> In case of error return the "ret" value.
> 
> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu at amd.com>
> ---
> Changes in v2:
> - Fixed the commit description.
> - Removed the newline.
> ---
>   drivers/firmware/firmware-zynqmp.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c
> index 43fb7fa778..8ea15c7ed3 100644
> --- a/drivers/firmware/firmware-zynqmp.c
> +++ b/drivers/firmware/firmware-zynqmp.c
> @@ -203,6 +203,8 @@ int zynqmp_pm_feature(const u32 api_id)
>   	/* Check feature check API version */
>   	ret = xilinx_pm_request(PM_FEATURE_CHECK, api_id, 0, 0, 0,
>   				ret_payload);
> +	if (ret)
> +		return ret;
>   
>   	/* Return feature check version */
>   	return ret_payload[1] & FIRMWARE_VERSION_MASK;

Applied.
M