[PATCH v3 04/32] cmd: Add a few more dependencies on CMDLINE

[Simon Glass]

Hi Heinrich,

On Wed, 18 Oct 2023 at 07:14, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> On 10/17/23 00:27, Simon Glass wrote:
> > Add this to some more commands to avoid build errors with sandbox.
> >
> > Note that this is a temporary solution to expose more problems. A later
> > patch puts these behind an 'if CMDLINE'
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > Changes in v3:
> > - Add an explation as to why this patch is here
> >
> >   cmd/Kconfig | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > index 5bc0a92d57ad..00a7f84bce99 100644
> > --- a/cmd/Kconfig
> > +++ b/cmd/Kconfig
> > @@ -231,6 +231,7 @@ menu "Boot commands"
> >
> >   config CMD_BOOTD
> >       bool "bootd"
> > +     depends on CMDLINE
>
> Why don't we simply use a single "if" for all commands?
> Adding the same dependency to 200+ commands does not feel right.
>
> If there is any CONFIG_CMD* that is needed without CMDLINE, then that
> code should move to lib/ or drivers/.

This is here to fix build failures at this point in the series.

One of the later patches does what you suggest (27 I think).

Regards,
Simon