[PATCH 1/9] DO NOT MERGE: arm: dts: k3-j7200-r5-common: Add pmic node for esm

[Nishanth Menon]

On 14:42-20231019, Thomas Richard wrote:
> On 10/16/23 18:29, Nishanth Menon wrote:
> > On 16:11-20231016, Thomas Richard wrote:
> >> From: Gowtham Tammana <g-tammana at ti.com>
> >>
> >> Add pmic tps659413 node needed for ESM error event handling.
> >>
> >> Signed-off-by: Gowtham Tammana <g-tammana at ti.com>
> >> Signed-off-by: Neha Malcom Francis <n-francis at ti.com>
> >> Signed-off-by: Thomas Richard <thomas.richard at bootlin.com>
> >> ---
> >>
> >>  arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 17 ++++++++++++++---
> >>  1 file changed, 14 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
> >> index e62f9218e8..2bf0d5e3c0 100644
> >> --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
> >> +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
> >> @@ -249,13 +249,24 @@
> >>  
> >>  &wkup_i2c0 {
> >>  	bootph-pre-ram;
> >> +	pinctrl-names = "default";
> >> +	pinctrl-0 = <&wkup_i2c0_pins_default>;
> >> +	clock-frequency = <400000>;
> >> +
> >> +	tps659413: tps659413 at 48 {
> >> +		compatible = "ti,tps659413";
> >> +		reg = <0x48>;
> >> +		bootph-pre-ram;
> >> +
> >> +		regulators_a: regulators {
> >> +			bootph-pre-ram;
> >> +		};
> >> +	};
> >> +
> >>  	lp876441: lp876441 at 4c {
> >>  		compatible = "ti,lp876441";
> >>  		reg = <0x4c>;
> >>  		bootph-pre-ram;
> >> -		pinctrl-names = "default";
> >> -		pinctrl-0 = <&wkup_i2c0_pins_default>;
> >> -		clock-frequency = <400000>;
> >>  
> >>  		regulators: regulators {
> >>  			bootph-pre-ram;
> >> -- 
> >> 2.39.2
> >>
> > 
> > Please send these changes upstream linux kernel.
> 
> Hi Nishanth,
> 
> I found this series
> (https://lore.kernel.org/all/20230810-tps6594-v6-0-2b2e2399e2ef@ti.com/)
> which includes a patch to create the two pmic nodes for j7200 target.
> It matches exactly my needs.
> 
> I found it was merged in TI linux kernel
> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi?h=ti-linux-6.1.y&id=0b3a445305b24aafba567909dac75961a0e8908c)

I will skip commenting on TI vendor kernel and bootloader stuff.
> 
> 
> But referring to your answer
> (https://lore.kernel.org/all/169164472311.19570.17843597381384613605.b4-ty@ti.com/)
> this series will not be merged upstream as is.
> 
> Should I send a single patch to declare pmics only for J7200 ?
> Could I just send a minimal definition of the pmics, or should I send a
> full definition (including regulators) ?
> 

It will be good to discuss kernel patches in kernel.org mailing lists :)

But yeah - that series was pretty much close to getting merged before
I had to drop when testing I do failed. If we are doing it, we'd need
to do as a full definition (including regulators).. Though, I am
disappointed at TI dropping the ball on this (Udit/Praneeth: hint -
this is blocking additional progress).

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D