[RESEND PATCH] board: ti: common: board_detect: Fix EEPROM offset read for 1-byte
Neha Malcom Francis
n-francis at ti.com
Fri Oct 20 17:29:02 CEST 2023
Hi Prasanth
On 20-Oct-23 12:31 PM, Prasanth Babu Mantena wrote:
> EEPROM detection logic in ti_i2c_eeprom_get() involves reading the total
> size followed by reading 1-byte size with an offset 1. This commit fixes
> the header matching issue in commit 9f393a2d7af8 ("board: ti: common:
> board_detect: Fix EEPROM read quirk for 2-byte").
>
> In the previous commit, the value with one offset is being read into
> offset_test, but the pointer used to match was still ep. After reading
> with an offset 1, the second byte of the header is compared with the 1-byte
> data read from EEPROM. This is taken care by comparing proper first byte
> value from the header.
>
> Signed-off-by: Prasanth Babu Mantena <p-mantena at ti.com>
> Fixes: 9f393a2d7af8 (board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte)
> ---
> Resending due to incorrect patch tag last time.
>
> board/ti/common/board_detect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/ti/common/board_detect.c b/board/ti/common/board_detect.c
> index 9a53884c98..17fe8f8069 100644
> --- a/board/ti/common/board_detect.c
> +++ b/board/ti/common/board_detect.c
> @@ -128,7 +128,7 @@ static int __maybe_unused ti_i2c_eeprom_get(int bus_addr, int dev_addr,
>
> rc = dm_i2c_read(dev, 0x1, &offset_test, sizeof(offset_test));
>
> - if (*((u32 *)ep) != (header & 0xFF))
> + if (offset_test != ((header >> 8) & 0xFF))
> one_byte_addressing = false;
>
> /* Corrupted data??? */
Thanks for catching this!
Reviewed-by: Neha Malcom Francis <n-francis at ti.com>
--
Thanking You
Neha Malcom Francis
More information about the U-Boot
mailing list