[PATCH v2 07/22] pinctrl: sunxi: remove GPIO_EXTRA_HEADER

Samuel Holland samuel at sholland.org
Sat Oct 21 10:57:37 CEST 2023


On 9/28/23 16:54, Andre Przywara wrote:
> U-Boot's generic GPIO_EXTRA_HEADER is a convenience symbol to allow code
> to more easily include platform specific GPIO headers. This should not
> be needed in a DM world anymore, since the generic GPIO framework
> handles that nicely.
> For Allwinner boards we still need to deal with non-DM GPIO in the SPL,
> but this should become the exception, not the rule.
> 
> Make this more obvious by removing the definition of GPIO_EXTRA_HEADER,
> and just force every legacy user of platform specific GPIO to include
> the new sunxi_gpio.h header explicitly. Everyone doing so should feel
> ashamed and should find a way to avoid it from now on.
> 
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> ---
>  arch/arm/Kconfig                                               | 1 -
>  arch/arm/mach-sunxi/board.c                                    | 1 +
>  arch/arm/mach-sunxi/dram_suniv.c                               | 2 +-
>  arch/arm/mach-sunxi/spl_spi_sunxi.c                            | 1 +
>  board/sunxi/board.c                                            | 1 +
>  board/sunxi/chip.c                                             | 2 +-
>  drivers/gpio/axp_gpio.c                                        | 1 +
>  drivers/gpio/sunxi_gpio.c                                      | 1 +
>  drivers/i2c/sun6i_p2wi.c                                       | 2 +-
>  drivers/i2c/sun8i_rsb.c                                        | 2 +-
>  drivers/mmc/sunxi_mmc.c                                        | 1 +
>  drivers/pinctrl/sunxi/pinctrl-sunxi.c                          | 1 +
>  drivers/video/hitachi_tx18d42vm_lcd.c                          | 1 +
>  drivers/video/ssd2828.c                                        | 1 -
>  drivers/video/sunxi/sunxi_display.c                            | 1 +
>  drivers/video/sunxi/sunxi_lcd.c                                | 1 +
>  arch/arm/include/asm/arch-sunxi/gpio.h => include/sunxi_gpio.h | 0
>  17 files changed, 14 insertions(+), 6 deletions(-)
>  rename arch/arm/include/asm/arch-sunxi/gpio.h => include/sunxi_gpio.h (100%)

Tested-by: Samuel Holland <samuel at sholland.org>



More information about the U-Boot mailing list