[PATCH v3 32/32] sandbox: Add a test for disabling CONFIG_CMDLINE

Simon Glass sjg at chromium.org
Sat Oct 21 17:44:03 CEST 2023


Hi Tom,

On Thu, 19 Oct 2023 at 07:57, Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Oct 19, 2023 at 08:00:00AM -0600, Simon Glass wrote:
> > Hi Tom,
> >
> > On Wed, 18 Oct 2023 at 20:32, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Mon, Oct 16, 2023 at 04:28:23PM -0600, Simon Glass wrote:
> > >
> > > > Now that everything is working, add a test to make sure that this
> > > > builds correctly.
> > > >
> > > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > > Reviewed-by: Tom Rini <trini at konsulko.com>
> > > > ---
> > > >
> > > > Changes in v3:
> > > > - Rebase on Tom's LONGHELP series
> > > > - Correct 'of' typo
> > > >
> > > >  test/py/tests/test_sandbox_opts.py | 20 ++++++++++++++++++++
> > > >  1 file changed, 20 insertions(+)
> > > >  create mode 100644 test/py/tests/test_sandbox_opts.py
> > >
> > > This is not doing the equivalent of:
> > > make sandbox_config
> > > sed -i -e 's/CONFIG_CMDLINE=y/CONFIG_CMDLINE=n/' .config
> > > make oldconfig
> > > make all
> >
> > Buildman should do that automatically...is something failing?
>
> Yes. https://source.denx.de/u-boot/u-boot/-/jobs/716843 fails, but
> shouldn't, and it's only the no LTO job, so maybe there's some conflict
> there?

For me this was the EFI patch to make it depend on net. Perhaps you
hit a different one?

I am seeing build errors with ~CMDLINE ~LTO with your series.

Regards,
Simon


More information about the U-Boot mailing list