[PATCH v1 2/2] imx: spl_imx_romapi: fix emmc fast boot mode case

Stefano Babic sbabic at denx.de
Thu Oct 26 10:36:10 CEST 2023


On 26.10.23 10:29, Rasmus Villemoes wrote:
> On 26/10/2023 09.32, Marcel Ziswiler wrote:
>> From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
>>
>> This fixes a regression in the eMMC fast boot mode case where the buffer
>> was missing 464 bytes.
>>
>> The code figures out how many bytes must at least be fetched to honor
>> the current read, rounds that up to the ss->pagesize [which is a no-op
>> in the USB download case because that has ->pagesize==1], fetches that
>> many bytes, but then recorded the original upper bound as the new end of
>> the valid data. However, this did not take into account the rounding up
>> to the ss->pagesize. Fix this by recording the actual bytes downloaded.
>>
>> Fixes: 4b4472438f5a ("imx: spl_imx_romapi: avoid tricky use of spl_load_simple_fit() to get full FIT size")
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
>>
> 
> Thanks for reporting and fixing this, and sorry for the trouble.
> 
> Acked-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> 

And thanks for all your work - I will apply this fix soon.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================



More information about the U-Boot mailing list