[PATCH v8 3/8] power: pmic: add the base MAX77663 PMIC support

[Tom Rini]

On Thu, Oct 26, 2023 at 05:49:01PM +0300, Svyatoslav Ryhel wrote:
> 
> 
> 25 жовтня 2023 р. 16:37:12 GMT+03:00, Tom Rini <trini at konsulko.com> написав(-ла):
> >On Wed, Oct 25, 2023 at 09:10:12AM +0300, Svyatoslav Ryhel wrote:
> >> вт, 24 жовт. 2023 р. о 22:18 Tom Rini <trini at konsulko.com> пише:
> >> >
> >> > On Tue, Oct 24, 2023 at 10:41:05AM +0300, Svyatoslav Ryhel wrote:
> >> >
> >> > > Add support to bind the regulators/child nodes with the pmic.
> >> > > Also adds the pmic i2c based read/write functions to access pmic
> >> > > registers.
> >> > >
> >> > > Signed-off-by: Svyatoslav Ryhel <clamor95 at gmail.com>
> >> > > Reviewed-by: Simon Glass <sjg at chromium.org>
> >> > [snip]
> >> > > diff --git a/drivers/power/pmic/max77663.c b/drivers/power/pmic/max77663.c
> >> > > new file mode 100644
> >> > > index 0000000000..4070235d3c
> >> > > --- /dev/null
> >> > > +++ b/drivers/power/pmic/max77663.c
> >> > > @@ -0,0 +1,86 @@
> >> > > +// SPDX-License-Identifier: GPL-2.0+
> >> > > +/*
> >> > > + *  Copyright(C) 2023 Svyatoslav Ryhel <clamor95 at gmail.com>
> >> > > + */
> >> > > +
> >> > > +#include <common.h>
> >> >
> >> > Should have noted sooner, sorry. Please don't use <common.h> in new
> >> > code, and audit the include list you have as well (this one looks
> >> > reasonable I suspect, all the same, so general advice).
> >> 
> >> Each and every driver in pmic dir has common.h so it was an obvious
> >> move to include it as well. I haven't seen that this header is deprecated,
> >> if so, sure, I will not include it further.
> >> 
> >> About auditing inclusions, I never include unnecessary headers and almost
> >> all the time run tests to determine the least amount of inclusions possible for
> >> correct build and work.
> >
> >Yes, it's more recently formally deprecated, and just removing it fro
> >existing drivers is on the TODO list.
> >
> 
> Should I reload patchset with requested changes?

Yes please.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231026/f24f6585/attachment.sig>