[PATCH 3/8] clk/qcom: move ipq4019 driver from mach-ipq40xx

Caleb Connolly caleb.connolly at linaro.org
Fri Oct 27 14:57:34 CEST 2023


[...]
>> diff --git a/arch/arm/mach-ipq40xx/clock-ipq4019.c b/drivers/clk/qcom/clock-ipq4019.c
>> similarity index 56%
>> rename from arch/arm/mach-ipq40xx/clock-ipq4019.c
>> rename to drivers/clk/qcom/clock-ipq4019.c
>> index c1d5c4ecdd81..04c99964df15 100644
>> --- a/arch/arm/mach-ipq40xx/clock-ipq4019.c
>> +++ b/drivers/clk/qcom/clock-ipq4019.c
>> @@ -12,12 +12,9 @@
[...]
>> -
>> -static const struct udevice_id msm_clk_ids[] = {
>> -       { .compatible = "qcom,gcc-ipq4019" },
> 
> This compatible should be moved to "clock-qcom.c".

Should all of the clock drivers have their udevice_id tables in
clock-qcom.c or just this one?

I'll note that I forgot to adjust the U_BOOT_DRIVER definition below to
be apq4019 specific, it shouldn't say "clk_msm".
> 
> -Sumit
> 
>> -       { }
>> -};
>> -
>> -U_BOOT_DRIVER(clk_msm) = {
>> -       .name           = "clk_msm",
>> -       .id             = UCLASS_CLK,
>> -       .of_match       = msm_clk_ids,
>> -       .ops            = &msm_clk_ops,
>> -       .priv_auto      = sizeof(struct msm_clk_priv),
>> -       .probe          = msm_clk_probe,
>> -};
>>
>> --
>> 2.42.0
>>

-- 
// Caleb (they/them)


More information about the U-Boot mailing list