[PATCH 2/3] arm: dts: k3-am625-verdin-wifi-dev-u-boot.dtsi: Fix DMA/Ethernet

Marcel Ziswiler marcel.ziswiler at toradex.com
Sat Oct 28 10:13:11 CEST 2023


On Fri, 2023-10-27 at 16:46 +0300, Roger Quadros wrote:
> Update main_bcdma and main_pktdma nodes for native configuration in the
> absence of DM services. u-boot k3-udma driver expects these additional
> register fields else probe will fail.
> 
> Reported-by: Nishanth Menon <nm at ti.com>
> Signed-off-by: Roger Quadros <rogerq at kernel.org>

With just one minor nitpick blow.

Tested-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>

> ---
>  .../dts/k3-am625-verdin-wifi-dev-u-boot.dtsi  | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm/dts/k3-am625-verdin-wifi-dev-u-boot.dtsi b/arch/arm/dts/k3-am625-verdin-wifi-dev-u-
> boot.dtsi
> index afa24d07a4..730cb21ce9 100644
> --- a/arch/arm/dts/k3-am625-verdin-wifi-dev-u-boot.dtsi
> +++ b/arch/arm/dts/k3-am625-verdin-wifi-dev-u-boot.dtsi
> @@ -42,6 +42,33 @@
>  	bootph-all;
>  };
>  
> +&main_bcdma {
> +	reg = <0x00 0x485c0100 0x00 0x100>,
> +	      <0x00 0x4c000000 0x00 0x20000>,
> +	      <0x00 0x4a820000 0x00 0x20000>,
> +	      <0x00 0x4aa40000 0x00 0x20000>,
> +	      <0x00 0x4bc00000 0x00 0x100000>,
> +	      <0x00 0x48600000 0x00 0x8000>,
> +	      <0x00 0x484a4000 0x00 0x2000>,
> +	      <0x00 0x484c2000 0x00 0x2000>;
> +	reg-names = "gcfg", "bchanrt", "rchanrt", "tchanrt",
> +		    "ringrt" , "cfg", "tchan", "rchan";
> +};
> +
> +&main_pktdma {
> +	bootph-all;

Ditto, I believe that property would usually be added as the last item of a node.

> +	reg = <0x00 0x485c0000 0x00 0x100>,
> +	      <0x00 0x4a800000 0x00 0x20000>,
> +	      <0x00 0x4aa00000 0x00 0x20000>,
> +	      <0x00 0x4b800000 0x00 0x200000>,
> +	      <0x00 0x485e0000 0x00 0x10000>,
> +	      <0x00 0x484a0000 0x00 0x2000>,
> +	      <0x00 0x484c0000 0x00 0x2000>,
> +	      <0x00 0x48430000 0x00 0x1000>;
> +	reg-names = "gcfg", "rchanrt", "tchanrt", "ringrt",
> +		    "cfg", "tchan", "rchan", "rflow";
> +};
> +
>  &cpsw3g {
>  	bootph-all;
>  };


More information about the U-Boot mailing list