[PATCH v2 8/8] usb: xhci: Add more debugging

Marek Vasut marex at denx.de
Sun Oct 29 15:36:14 CET 2023


On 10/29/23 07:37, Hector Martin wrote:
> A bunch of miscellaneous debug messages to aid in working out USB
> issues.
> 
> Signed-off-by: Hector Martin <marcan at marcan.st>
> ---
>   drivers/usb/host/xhci-ring.c | 29 ++++++++++++++++++++++++++---
>   1 file changed, 26 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index b60661fe05e7..dabe6cf86af2 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -214,6 +214,9 @@ static dma_addr_t queue_trb(struct xhci_ctrl *ctrl, struct xhci_ring *ring,
>   
>   	addr = xhci_trb_virt_to_dma(ring->enq_seg, (union xhci_trb *)trb);
>   
> +	debug("trb @ %llx: %08x %08x %08x %08x\n", addr,
> +	      trb_fields[0], trb_fields[1], trb_fields[2], trb_fields[3]);
> +

Could you please use dev_dbg() instead of debug() ?
That way you'd also get the device prefix in the output.


More information about the U-Boot mailing list