[PATCH v2] dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation

Tom Rini trini at konsulko.com
Mon Oct 30 16:24:38 CET 2023


On Sun, Aug 20, 2023 at 10:03:18PM +0000, Jonas Karlman wrote:

> Nodes with bootph-pre-sram/ram props are bound in multiple phases:
> 1. At TPL (bootph-pre-sram) or SPL (bootph-pre-ram) phase
> 2. At U-Boot proper pre-relocation phase
> 3. At U-Boot proper normal phase
> 
> However the binding and U-Boot Driver Model documentation indicate that
> only nodes marked with bootph-all or bootph-some-ram should be bound in
> the U-Boot proper pre-relocation phase.
> 
> Change ofnode_pre_reloc to report a node with bootph-pre-ram/sram prop
> with a pre-reloc status only after U-Boot proper pre-relocation phase.
> Also update the ofnode_pre_reloc documentation to closer reflect the
> binding and driver model documentation.
> 
> This changes behavior of what nodes are bound in the U-Boot proper
> pre-relocation phase. Change to bootph-all or add bootph-some-ram prop
> to restore prior behavior.
> 
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
> Reviewed-by: Simon Glass <sjg at chromium.org>

I'm following up here now that this is committed because there's been a
large number of commits to update dts files because of the change this
commit makes. And I know there's other platforms still broken that need
the same update. And it seems the change is almos always to mark more
(or all!) nodes as bootph-all. So, is this patch really correct, and
really what we want to be doing here? I was not expecting this much
fallout when I saw this come in. Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231030/013277e6/attachment.sig>


More information about the U-Boot mailing list