[PATCH 1/2] riscv: dts: jh7110: Add a gpio-restart node

Tom Rini trini at konsulko.com
Tue Oct 31 14:01:01 CET 2023


On Tue, Oct 31, 2023 at 05:24:38PM +0900, Jaehoon Chung wrote:

> Add gpio-restart node to do reset.
> 
> Before applied this patch, System Reset Extension doesn't appear with
> sbi command.
> 
> OpenSBI 1.3
> Machine:
>   Vendor ID 489
>   Architecture ID 8000000000000007
>   Implementation ID 4210427
> Extensions:
>   sbi_set_timer
>   sbi_console_putchar
> ...[snip]...
>   IPI Extension
>   RFENCE Extension
>   Hart State Management Extension
>   Performance Monitoring Unit Extension
> 
> After applied this patch, System Reset Extension is supported from SBI.
> 
> OpenSBI 1.3
> Machine:
>   Vendor ID 489
>   Architecture ID 8000000000000007
>   Implementation ID 4210427
> Extensions:
>   sbi_set_timer
>   sbi_console_putchar
> ...[snip]...
>   IPI Extension
>   RFENCE Extension
>   Hart State Management Extension
>   System Reset Extension
>   Performance Monitoring Unit Extension
> 
> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
> ---
>  arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi
> index e40f57a15080..e94f9fe826a8 100644
> --- a/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi
> +++ b/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi
> @@ -34,6 +34,11 @@
>  		device_type = "memory";
>  		reg = <0x0 0x40000000 0x2 0x0>;
>  	};
> +
> +	gpio-restart {
> +		compatible = "gpio-restart";
> +		gpios = <&sysgpio 35 GPIO_ACTIVE_HIGH>;
> +	};
>  };
>  
>  &osc {

My only concern with this change (and a few other similar things I've
seen of late) is where is this change with respect to the upstream
kernel? The goal is the dts files should be able to be dropped in from
the kernel (except for -u-boot.dtsi), so we don't want to have changed
get dropped when they're re-synced.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231031/22c71aef/attachment.sig>


More information about the U-Boot mailing list