[PATCH 09/31] rockchip: rk3399: Add a default spl-boot-order prop

Quentin Schulz quentin.schulz at theobroma-systems.com
Tue Apr 2 16:02:12 CEST 2024


Hi Jonas,

On 3/31/24 22:28, Jonas Karlman wrote:
> A lot of RK3399 boards use a u-boot,spl-boot-order of "same-as-spl",
> &sdhci and &sdmmc.
> 
> Move this to rk3399-u-boot.dtsi and make this default for boards
> currently missing a u-boot,spl-boot-order prop.
> 
> The &spi_flash reference has been dropped from spl-boot-order now that
> boot source id is cached and "same-as-spl" can be resolved into the SPI
> flash node.
> 

This is not really the same thing.

This prevents from having U-Boot proper in SPI and TPL+SPL on eMMC/SD 
card. Is this a real usecase? I don't know, we do support it on Puma 
(though I know you haven't changed it in this commit). I guess we could 
still have the devices with SPI flashes have their own 
u-boot,spl-boot-order if they want.

So, in short, I would at the very least document this new limitation in 
the commit log but have nothing against the change (my board not being 
impacted by it :) ).

Cheers,
Quentin


More information about the U-Boot mailing list