[PATCH v2 1/3] mmc: Convert hs400_tuning flag from u8 to bool

Jaehoon Chung jh80.chung at samsung.com
Wed Apr 3 03:05:00 CEST 2024


On 2/25/24 07:32, Marek Vasut wrote:
> This hs400_tuning is a flag, make it bool. No functional change.
> This will be useful in the following patch, which adds another
> more generic flag, where the compiler can better use the space
> now reserved for the u8 to store more flags in it.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>

Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Best Regards,
Jaehoon Chung

> ---
> Cc: Hai Pham <hai.pham.ud at renesas.com>
> Cc: Jaehoon Chung <jh80.chung at samsung.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
> Cc: Paul Barker <paul.barker.ct at bp.renesas.com>
> Cc: Peng Fan <peng.fan at nxp.com>
> Cc: Sean Anderson <seanga2 at gmail.com>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh at renesas.com>
> ---
> V2: Use bool var:1;
> ---
>  drivers/mmc/mmc.c | 4 ++--
>  include/mmc.h     | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 83f9ae8bb7d..07d87c993a6 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -2027,9 +2027,9 @@ static int mmc_select_hs400(struct mmc *mmc)
>  	mmc_set_clock(mmc, mmc->tran_speed, false);
>  
>  	/* execute tuning if needed */
> -	mmc->hs400_tuning = 1;
> +	mmc->hs400_tuning = true;
>  	err = mmc_execute_tuning(mmc, MMC_CMD_SEND_TUNING_BLOCK_HS200);
> -	mmc->hs400_tuning = 0;
> +	mmc->hs400_tuning = false;
>  	if (err) {
>  		debug("tuning failed\n");
>  		return err;
> diff --git a/include/mmc.h b/include/mmc.h
> index 2b9a6aa8ee0..afca123b386 100644
> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -736,7 +736,7 @@ struct mmc {
>  				  * accessing the boot partitions
>  				  */
>  	u32 quirks;
> -	u8 hs400_tuning;
> +	bool hs400_tuning:1;
>  
>  	enum bus_mode user_speed_mode; /* input speed mode from user */
>  };



More information about the U-Boot mailing list