[PATCH v2 6/6] spinand: bind UBI block

Chuanhong Guo gch981213 at gmail.com
Fri Apr 5 06:40:34 CEST 2024


Hi!

On Thu, Apr 4, 2024 at 4:02 PM Alexey Romanov
<avromanov at salutedevices.com> wrote:
> > > +#include <ubi_uboot.h>
> > >  #include <dm/device_compat.h>
> > >  #include <dm/devres.h>
> > >  #include <dm/uclass.h>
> > > @@ -1182,8 +1183,13 @@ static int spinand_bind(struct udevice *dev)
> > >  {
> > >         if (blk_enabled()) {
> > >                 struct spinand_plat *plat = dev_get_plat(dev);
> > > +               int ret;
> > > +
> > > +               ret = mtd_bind(dev, &plat->mtd);
> > > +               if (ret)
> > > +                       return ret;
> > >
> > > -               return mtd_bind(dev, &plat->mtd);
> > > +               return ubi_bind(dev);
> >
> > Is this expecting the entire SPI-NAND covered by a single UBI partition?
>
> Why? Nah.

I can't find the code it's patching in my outdated local tree and
made a wrong guess. Sorry for my ignorance.

> ubi_bind() just create block device and bind it to SPI-NAND device.
> When working with this block device user must specify, which SPI-NAND
> partition UBI is located on.
>

And thanks for the explanation!

-- 
Regards,
Chuanhong Guo


More information about the U-Boot mailing list