[PATCH v2 05/14] rockchip: rk3308: Enable random generator

[Dragan Simic]

Hello Quentin,

On 2024-04-09 17:45, Quentin Schulz wrote:
> Hi Jonas,
> 
> On 4/8/24 20:14, Jonas Karlman wrote:
>> The RK3308 SoC contain a crypto engine block that can generate random
>> numbers.
>> 
>> Add rng node to soc u-boot.dtsi and enable Kconfig options to take
>> advantage of the random generator.
>> 
>> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
>> ---
>> v2: No change
>> ---
>>   arch/arm/dts/rk3308-u-boot.dtsi | 5 +++++
>>   arch/arm/mach-rockchip/Kconfig  | 2 ++
>>   2 files changed, 7 insertions(+)
>> 
>> diff --git a/arch/arm/dts/rk3308-u-boot.dtsi 
>> b/arch/arm/dts/rk3308-u-boot.dtsi
>> index 436f66d1b87d..fa31c838d34d 100644
>> --- a/arch/arm/dts/rk3308-u-boot.dtsi
>> +++ b/arch/arm/dts/rk3308-u-boot.dtsi
>> @@ -26,6 +26,11 @@
>>   			reg = <0x07 0x10>;
>>   		};
>>   	};
>> +
>> +	rng: rng at ff2f0000 {
>> +		compatible = "rockchip,cryptov2-rng";
>> +		reg = <0x0 0xff2f0000 0x0 0x4000>;
> 
> Downstream says something different:
> 
> https://github.com/rockchip-linux/kernel/blob/develop-5.10/arch/arm64/boot/dts/rockchip/rk3308.dtsi#L1007-L1020
> 
> I couldn't quickly find the TRM for the RK3308 so cannot check myself 
> :/

The RK3308 TRM can be found on the link below.  BTW, there's also
a rather interesting PDF file that describes a node shrink of the
RK3308, the so-called S-version chip.

https://dl.radxa.com/rockpis/docs/hw/datasheets/

> Also seems to be missing clocks and resets?