[PATCH v3] rockchip: px30-board-tpl: Sync ifdef guards with full TPL
Quentin Schulz
quentin.schulz at theobroma-systems.com
Wed Apr 17 14:54:14 CEST 2024
Hi Lukasz,
On 4/17/24 13:21, lukasz.czechowski at thaumatec.com wrote:
> From: Lukasz Czechowski <lukasz.czechowski at thaumatec.com>
>
> Display TPL init information message only when TPL_BANNER_PRINT
> configuration entry is set. This allows to disable information
> message in case logs on UART are unwanted.
> Update parent ifdef condition to check also CONFIG_TPL_SERIAL
> to match logic of the non-PX30 TPL implementation.
>
> Signed-off-by: Lukasz Czechowski <lukasz.czechowski at thaumatec.com>
>
When someone gives a tag (Acked-by, Reviewed-by, Tested-by, ...) on a
version and you send a new one, it's best to include this in the commit
log now (above your Signed-off-by if I remember correctly) if and only
if the content only changed a bit (like no big logic change or rewrite).
So here, my Reviewed-by would have been nice since I gave it in the v2
:) (please do not send a v4 for this :) )
b4 does this with `b4 trailers -u` automatically by the way :)
Reviewed-by: Quentin Schulz <quentin.schulz at theobroma-systems.com>
Thanks,
Quentin
More information about the U-Boot
mailing list