[PATCH v3 19/28] rockchip: rk3588-toybrick: Use pinctrl and aliases in SPL

Kever Yang kever.yang at rock-chips.com
Mon Apr 22 10:08:25 CEST 2024


On 2024/4/22 14:28, Jonas Karlman wrote:
> Pinctrl must be configured for eMMC, SD-card and SPI flash to
> successfully read FIT from all possible fallback media in SPL.
>
> Include pinctrl props and enable the SPL_PINCTRL Kconfig option to
> ensure FIT can be loaded from eMMC, SD-card and SPI flash.
>
> Also enable the SPL_DM_SEQ_ALIAS Kconfig option to ensure that the
> storage device sequence number matches in both SPL and U-Boot proper.
>
> Fixes: 9fdd9a546986 ("board: rockchip: add Rockchip Toybrick TB-RK3588X board")
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
> v3: Drop PHY_ROCKCHIP_NANENG_COMBOPHY, usb3/sata/pcie is not enabled
> v3: Split Makefile changes to a separate patch
> v2: Fix Makefile entry from .dts to .dtb (Quentin)
> ---
>   configs/toybrick-rk3588_defconfig | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/configs/toybrick-rk3588_defconfig b/configs/toybrick-rk3588_defconfig
> index 38fc7906eef2..8d773603db0b 100644
> --- a/configs/toybrick-rk3588_defconfig
> +++ b/configs/toybrick-rk3588_defconfig
> @@ -33,8 +33,9 @@ CONFIG_CMD_REGULATOR=y
>   # CONFIG_SPL_DOS_PARTITION is not set
>   CONFIG_SPL_OF_CONTROL=y
>   CONFIG_OF_LIVE=y
> -CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
> +CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
>   CONFIG_ENV_IS_IN_MMC=y
> +CONFIG_SPL_DM_SEQ_ALIAS=y
>   CONFIG_SPL_REGMAP=y
>   CONFIG_SPL_SYSCON=y
>   CONFIG_SPL_CLK=y
> @@ -53,6 +54,7 @@ CONFIG_PHY_REALTEK=y
>   CONFIG_DWC_ETH_QOS=y
>   CONFIG_DWC_ETH_QOS_ROCKCHIP=y
>   CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> +CONFIG_SPL_PINCTRL=y
>   CONFIG_PWM_ROCKCHIP=y
>   CONFIG_SPL_RAM=y
>   CONFIG_BAUDRATE=1500000


More information about the U-Boot mailing list