New Defects reported by Coverity Scan for Das U-Boot

[Ilias Apalodimas]

Hi Tom,

Thanks! Already sent a fix for UEFI

On Tue, 23 Apr 2024 at 00:48, Tom Rini <trini at konsulko.com> wrote:
>
> Here's the latest report.
>
> ---------- Forwarded message ---------
> From: <scan-admin at coverity.com>
> Date: Mon, Apr 22, 2024 at 3:23 PM
> Subject: New Defects reported by Coverity Scan for Das U-Boot
> To: <tom.rini at gmail.com>
>
>
> Hi,
>
> Please find the latest report on new defect(s) introduced to Das
> U-Boot found with Coverity Scan.
>
> 2 new defect(s) introduced to Das U-Boot found with Coverity Scan.
> 7 defect(s), reported by Coverity Scan earlier, were marked fixed in
> the recent build analyzed by Coverity Scan.
>
> New defect(s) Reported-by: Coverity Scan
> Showing 2 of 2 defect(s)
>
>
> ** CID 492766:  Control flow issues  (DEADCODE)
> /lib/efi_loader/efi_var_mem.c: 236 in efi_var_mem_init()
>
>
> ________________________________________________________________________________________________________
> *** CID 492766:  Control flow issues  (DEADCODE)
> /lib/efi_loader/efi_var_mem.c: 236 in efi_var_mem_init()
> 230             memset(efi_var_buf, 0, EFI_VAR_BUF_SIZE);
> 231             efi_var_buf->magic = EFI_VAR_FILE_MAGIC;
> 232             efi_var_buf->length = (uintptr_t)efi_var_buf->var -
> 233                                   (uintptr_t)efi_var_buf;
> 234
> 235             if (ret != EFI_SUCCESS)
> >>>     CID 492766:  Control flow issues  (DEADCODE)
> >>>     Execution cannot reach this statement: "return ret;".
> 236                     return ret;
> 237             ret =
> efi_create_event(EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE, TPL_CALLBACK,
> 238
> efi_var_mem_notify_virtual_address_map, NULL,
> 239                                    NULL, &event);
> 240             if (ret != EFI_SUCCESS)
> 241                     return ret;
>
> ** CID 492765:  Uninitialized variables  (UNINIT)
>
>
> ________________________________________________________________________________________________________
> *** CID 492765:  Uninitialized variables  (UNINIT)
> /net/bootp.c: 888 in dhcp_process_options()
> 882                             net_root_path[size] = 0;
> 883                             break;
> 884                     case 28:        /* Ignore Broadcast Address Option */
> 885                             break;
> 886                     case 40:        /* NIS Domain name */
> 887                             if (net_nis_domain[0] == 0) {
> >>>     CID 492765:  Uninitialized variables  (UNINIT)
> >>>     Using uninitialized value "size" when calling "truncate_sz".
> 888                                     size = truncate_sz("NIS Domain Name",
> 889                                             sizeof(net_nis_domain), size);
> 890                                     memcpy(&net_nis_domain, popt + 2, size);
> 891                                     net_nis_domain[size] = 0;
> 892                             }
> 893                             break;
>
>
> --
> Tom