[PATCH v2 3/3] board: starfive: Call spl_dram_init() for DRAM initialization

Heinrich Schuchardt xypron.glpk at gmx.de
Tue Apr 23 14:22:30 CEST 2024


On 23.04.24 11:14, lukas.funke-oss at weidmueller.com wrote:
> From: Lukas Funke <lukas.funke at weidmueller.com>
>
> Call spl_dram_init() since this is commonly used for dram initialization
> in u-boot.
>
> Signed-off-by: Lukas Funke <lukas.funke at weidmueller.com>
> ---
>
> Changes in v2:
>   - capitalized acronym DRAM
>
>   board/starfive/visionfive2/spl.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/starfive/visionfive2/spl.c b/board/starfive/visionfive2/spl.c
> index 45848db6d8..ca61b5be22 100644
> --- a/board/starfive/visionfive2/spl.c
> +++ b/board/starfive/visionfive2/spl.c
> @@ -285,9 +285,9 @@ int spl_board_init_f(void)
>
>   	jh7110_jtag_init();
>
> -	ret = spl_soc_init();
> +	ret = spl_dram_init();

We want to be able to use git bisect. This requires that the source
builds after each individual patch.

This change must be in the same patch in which you rename the function
for the VisionFive 2.

Please, resubmit your series with two patches: one for SiFive, one for
StarFive.

Best regards

Heinrich

>   	if (ret) {
> -		debug("JH7110 SPL init failed: %d\n", ret);
> +		debug("JH7110 DRAM init failed: %d\n", ret);
>   		return ret;
>   	}
>



More information about the U-Boot mailing list