[PATCH v2] usb: cdns3: gadget.c: Set fast access bit

Marek Vasut marex at denx.de
Tue Apr 23 14:53:49 CEST 2024


On 4/23/24 10:24 AM, Ravi Gunasekaran wrote:
> From: Aswath Govindraju <a-govindraju at ti.com>
> 
> When the device port is in a low power state [U3/L2/Not Connected],
> accesses to usb device registers may take a long time. This could lead to
> potential core hang when the controller registers are accessed after the
> port is disabled by setting DEVDS field. Setting the fast register access
> bit ensures that the PHY clock is keeping up in active state.
> 
> Therefore, set fast access bit to ensure the accesses to device registers
> are quick even in low power states.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju at ti.com>
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran at ti.com>
> Reviewed-by: Roger Quadros <rogerq at kernel.org>
> ---
> v1 was posted and was reviewed as well. But it did not get merged.
> This change is present in upstream linux kernel as well.
> Upstream Linux kernel commit: b5148d946f45 ("usb: cdns3: gadget: set fast access bit")

This commit ^ should be mentioned in the commit message.

With that fixed:

Reviewed-by: Marek Vasut <marex at denx.de>

Thanks !


More information about the U-Boot mailing list