[PATCH v2 0/2] i2c: Add support for Qualcomm Generic Interface (GENI) I2C controller

Heiko Schocher hs at denx.de
Thu Apr 25 14:54:03 CEST 2024


Hello Caleb,

On 25.04.24 14:44, Caleb Connolly wrote:
> Hi Heiko,
> 
> On 25/04/2024 06:28, Heiko Schocher wrote:
>> Hello Caleb,
>>
>> On 23.04.24 13:43, Caleb Connolly wrote:
>>>
>>> On Mon, 22 Apr 2024 11:33:51 +0200, Neil Armstrong wrote:
>>>> Add Support for the Qualcomm Generic Interface (GENI) I2C interface
>>>> found on newer Qualcomm SoCs.
>>>>
>>>> The Generic Interface (GENI) is a firmware based Qualcomm Universal
>>>> Peripherals (QUP) Serial Engine (SE) Wrapper which can support multiple
>>>> bus protocols depending on the firmware type loaded at early boot time
>>>> based on system configuration.
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>
>> Hmm.. where do you have them applied?
> 
> That would be 
> https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commits/qcom-main/?ref_type=HEADS

Ah, thanks!

> I'll be sure to include a link next time.
>>
>> At least you should wait for an Acked-by from me! Especially in xz exploit
>> times, we really should give custodians some time...
> 
> My apologies, I got a bit of tunnel vision with all the Qualcomm patches we have flying around and 
> totally neglected to find out how you prefer to handle new drivers in i2c.
> 
> I'm happy for patches to go through your tree if you'd prefer.

It is fine for me, when you pick it up.

>>
>> v2 was posted 22.04.2024 11:33 and you applied it one day after!
>> (And yes, I was on holiday...)
> 
> Even so, it would have been fine to wait a few more days for your ack and/or let you pick this up.

Yep, no problem (as patch looks good for me)! Next time simply wait
for an Ack (or trigger me)

;-)

>>
>> But okay, v2 patchseries looks good to me...
> 
> Thanks,

bye,
Heiko

>>
>>>
>>> [1/2] i2c: Add support for Qualcomm Generic Interface (GENI) I2C controller
>>>        commit: 75db9ede12d06693a3ced8c901b74065a1922a23
>>> [2/2] configs: qcom_defconfig: enable GENI I2C Driver
>>>        commit: ad12acd7a8f5aeea5816d5c2fc37c205c403eee0
>>>
>>> Best regards,
>>>
>>
>> bye,
>> Heiko
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list