[EXT] Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG

[Gaurav Jain]

Hi Marek

> -----Original Message-----
> From: Marek Vasut <marex at denx.de>
> Sent: Friday, April 26, 2024 9:33 AM
> To: tharvey at gateworks.com
> Cc: u-boot at lists.denx.de; Angelo Dureghello <angelo at kernel-space.org>;
> Emanuele Ghidoli <emanuele.ghidoli at toradex.com>; Fabio Estevam
> <festevam at gmail.com>; Gaurav Jain <gaurav.jain at nxp.com>; Heinrich
> Schuchardt <xypron.glpk at gmx.de>; Michal Simek <michal.simek at amd.com>;
> Simon Glass <sjg at chromium.org>; Stefan Roese <sr at denx.de>; Sughosh Ganu
> <sughosh.ganu at linaro.org>; Svyatoslav Ryhel <clamor95 at gmail.com>; Tom Rini
> <trini at konsulko.com>
> Subject: [EXT] Re: [PATCH 2/3] crypto/fsl: Introduce SPL_FSL_CAAM_RNG
> 
> Caution: This is an external email. Please take care when clicking links or opening
> attachments. When in doubt, report the message using the 'Report this email'
> button
> 
> 
> On 4/26/24 2:16 AM, Tim Harvey wrote:
> 
> >> diff --git a/drivers/crypto/fsl/Makefile
> >> b/drivers/crypto/fsl/Makefile index 7a2543e16cc..4fbce519a0b 100644
> >> --- a/drivers/crypto/fsl/Makefile
> >> +++ b/drivers/crypto/fsl/Makefile
> >> @@ -6,6 +6,6 @@ obj-y += sec.o
> >>   obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o
> >>   obj-$(CONFIG_CMD_BLOB)$(CONFIG_IMX_CAAM_DEK_ENCAP) += fsl_blob.o
> >>   obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o
> >> -obj-$(CONFIG_FSL_CAAM_RNG) += rng.o
> >> +obj-$(CONFIG_$(SPL_TPL_)FSL_CAAM_RNG) += rng.o
> >>   obj-$(CONFIG_FSL_DCP_RNG) += dcp_rng.o
> >>   obj-$(CONFIG_FSL_MFGPROT) += fsl_mfgprot.o
> >> --
> >> 2.43.0
> >>
> >
> > Marek,
> 
> Hi,
> 
> > Thanks - this series does solve the issue I am seeing in the SPL when
> > enabling DM_RNG. Is this going to cause an issue for people who expect
> > it to be currently enabled and now have to manually enable it?
> 
> That's a good question. If I do '$ git grep FSL_CAAM_RNG' , there seem to be no
> users, so I don't think we need to worry here, right ?
> 
> With SPL_DM_RNG i.e. 1/3 I am a bit more concerned. But, looking at the users
> that enable DM_RNG, I am not seeing any obvious ones that would require
> SPL_DM_RNG too. What do you think ?

FSL_CAAM_RNG is enabled based on DM_RNG. This patch will disable the build of drivers/crypto/fsl/rng.c in SPL.

Regards
Gaurav Jain