[PATCH v4 14/25] efi_loader: Avoid assigning desc in efi_mem_carve_out()
Simon Glass
sjg at chromium.org
Sun Dec 1 16:24:33 CET 2024
Rather than assigning desc and then changing two fields, assign all four
fields, for clarity.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
(no changes since v1)
lib/efi_loader/efi_memory.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c
index 83f2e32b9a4..b51bb367899 100644
--- a/lib/efi_loader/efi_memory.c
+++ b/lib/efi_loader/efi_memory.c
@@ -268,9 +268,10 @@ static s64 efi_mem_carve_out(struct efi_mem_list *map,
newmap = calloc(1, sizeof(*newmap));
if (!newmap)
return EFI_CARVE_OUT_OF_RESOURCES;
- newmap->desc = map->desc;
+ newmap->desc.type = map->desc.type;
newmap->desc.physical_start = carve_start;
newmap->desc.num_pages = (map_end - carve_start) >> EFI_PAGE_SHIFT;
+ newmap->desc.attribute = map->desc.attribute;
/* Insert before current entry (descending address order) */
list_add_tail(&newmap->link, &map->link);
--
2.43.0
More information about the U-Boot
mailing list