[PATCH v1] doc: remove redundant Rockchip bindings

Johan Jonker jbx6244 at gmail.com
Tue Dec 3 02:08:04 CET 2024



On 12/2/24 23:54, Jonas Karlman wrote:
> Hi Johan,
> 
> On 2024-11-30 22:18, Johan Jonker wrote:
>> Most Rockchip device tree related bindings are converted to YAML
>> and available in the U-boot /dts/upstream/Bindings/ directory.
>> Remove all redundant U-boot entries.
>>
>> Signed-off-by: Johan Jonker <jbx6244 at gmail.com>
>> ---
>>  .../clock/rockchip,rk3188-cru.txt             |  61 -------
>>  .../clock/rockchip,rk3288-cru.txt             |  61 -------
>>  doc/device-tree-bindings/clock/rockchip.txt   |  77 ---------
>>  .../pinctrl/rockchip,pinctrl.txt              | 157 ------------------
>>  .../thermal/rockchip-thermal.txt              |  68 --------
>>  doc/device-tree-bindings/usb/dwc2.txt         |   4 -
>>  .../video/rockchip-lvds.txt                   |  77 ---------
>>  7 files changed, 505 deletions(-)
>>  delete mode 100644 doc/device-tree-bindings/clock/rockchip,rk3188-cru.txt
>>  delete mode 100644 doc/device-tree-bindings/clock/rockchip,rk3288-cru.txt
> 

> The rockchip,rk3288-cru.txt file is also removed in:
> 
> rockchip: rk3288: Use rk3288-cru.h from dts/upstream
> https://patchwork.ozlabs.org/project/uboot/patch/20241109210427.884888-4-jonas@kwiboo.se/

I'm neutral here, up to the maintainers.
As long as we get rid of it.
If I'm a little more strict I would say that the commit message/title must match the action.
They always say one action at the time.
So when a title says "Use rk3288-cru.h ..." and something else as well...

Just to let you know I plan to do something similar to rk3066/rk3166.

Johan

===

1:
Could someone add mmc aliases to rk3288.dtsi in mainline and remove the mshc ones?

2:
Could these boards upgrade upstream as well?
http://patchwork.ozlabs.org/project/uboot/patch/20220415212145.2276-14-jbx6244@gmail.com/
http://patchwork.ozlabs.org/project/uboot/patch/20220415212145.2276-13-jbx6244@gmail.com/

> 
> Regards,
> Jonas
> 
>>  delete mode 100644 doc/device-tree-bindings/clock/rockchip.txt
>>  delete mode 100644 doc/device-tree-bindings/pinctrl/rockchip,pinctrl.txt
>>  delete mode 100644 doc/device-tree-bindings/thermal/rockchip-thermal.txt
>>  delete mode 100644 doc/device-tree-bindings/video/rockchip-lvds.txt
> 
> [snip]



More information about the U-Boot mailing list