[PATCH v2 0/7] efi_loader: Add support for logging to a buffer

[Heinrich Schuchardt]

Am 3. Dezember 2024 01:23:26 MEZ schrieb Simon Glass <sjg at chromium.org>:
>Hi Heinrich,
>
>On Sun, 1 Dec 2024 at 17:24, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>
>> Am 2. Dezember 2024 01:12:36 MEZ schrieb Simon Glass <sjg at chromium.org>:
>> >It is a bit of a pain to log EFI boot-services calls at present. The
>> >output goes to the console so cannot easily be inspected later. Also it

You could use U-Boot's syslog driver. Or Linux tee command to solve the problem.

Both would allow post mortem analysis. Post mortem analysis is not possible when using a buffer in U-Boot.

So this series seems to be less then ideal.

>> >would be useful to be able to store the log and review it later, perhaps
>> >after something has gone wrong.
>> >
>> >This series makes a start on implementing a log-to-buffer feature. It
>> >provides a simple 'efidebug log' command to inspect the buffer. For now,
>> >only memory allocations are logged.
>>
>> In my previous review I suggested to move your work to the level of the logging library lib/log.c.
>
>Well, we could do that, if we actually have a need for programmatic
>logging of other subsystems.

Just do it right the first time.

Best regards

Heinrich

>
>>
>> Why are you reiterating your series without exposing why an EFI specific solution. should be desireable?
>
>I don't see that need yet, or at least, not for the purpose I am
>heading towards. In any case, we can easily refactor the code later if
>it is needed. For now I believe that this logging feature will help to
>tame some of the troubles we have.
>
>[..]
>
>Regards,
>Simon