[PATCH 2/2] boot: android: Add bootconfig support

[Guillaume LA ROQUE]

Le 03/12/2024 à 01:34, Tom Rini a écrit :
> On Mon, Dec 02, 2024 at 05:20:20PM -0700, Simon Glass wrote:
>> Hi Guillaume,
>>
>> On Mon, 2 Dec 2024 at 01:03, Guillaume LA ROQUE <glaroque at baylibre.com> wrote:
>>> Hi,
>>>
>>> Le 30/11/2024 à 21:24, Simon Glass a écrit :
>>>> Hi Guillaume,
>>>>
>>>> On Thu, 28 Nov 2024 at 03:15, Guillaume La Roque <glaroque at baylibre.com> wrote:
>>>>> For android vendor boot image version 4 bootconfig is mandatory.[1]
>>>>>
>>>>> In the android_image_get_ramdisk function, after copying both vendor and
>>>>> boot ramdisks, we extract all androidboot.* entries from the kernel
>>>>> command line. These entries are added to the bootconfig section.
>>>>> We then update the sizes of the ramdisk and bootconfig.
>>>>> Finally, all androidboot.* entries are removed from the kernel command
>>>>> line.
>>>>>
>>>>> [1] https://source.android.com/docs/core/architecture/partitions/vendor-boot-partitions#vendor-boot-partition-v4
>>>>> Co-developed-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>
>>>>> Signed-off-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>
>>>>> Signed-off-by: Guillaume La Roque <glaroque at baylibre.com>
>>>>> ---
>>>>>    boot/image-android.c | 29 +++++++++++++++++++++++++++++
>>>>>    1 file changed, 29 insertions(+)
>>>>>
>>>> I am not seeing any tests for this code. Can you please update the
>>>> test to cover this?
>>> i don't know if it's possible with test framework in uboot, to validate
>>> bootconfig raw partition is reading by android kernel. i don't really
>>> know how i can do this , if you can say me if it's something possible or
>>> not .
>> We don't have a way to boot a kernel (yet), but we do have tests that
>> check things are correct - e.g. bootflow_android() - and after a
>> 'fake' boot - e.g. bootflow_scan_boot()
> We already have a test that boots the kernel, test/py/tests/test_net_boot.py


Thanks for your feedback i will check all of this and will work on test 
for bootconfig..

Guillaume

>