[PATCH v7 08/14] efi_loader: net: set EFI bootdevice device path to HTTP when loaded from wget

[Heinrich Schuchardt]

On 05.12.24 02:30, Tom Rini wrote:
> On Wed, Dec 04, 2024 at 12:05:23AM -0300, Adriano Cordova wrote:
>
>> Set the device path of the efi boot device to an HTTP device path
>> (as formed by efi_dp_from_http) when the next boot stage is loaded
>> using wget (i.e., when wget is used with wget_info.set_bootdev=1).
>>
>> When loaded from HTTP, the device path should account for it so that
>> the next boot stage is aware (e.g. grub only loads its http stack if
>> it itself was loaded from http, and it checks this from its device path).
>>
>> Signed-off-by: Adriano Cordova <adrianox at gmail.com>
>> Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>
> I know this is applied now, but after re-checking some things in one of
> my labs, this breaks test_efi_helloworld_builtin on rpi_3 at least (and
> possibly others). There is no output from "bootefi hello".
>

Hello Tom,

None of the Raspberry Pi 3 related defconfigs enables bootefi hello:

rpi_3_32b_defconfig # CONFIG_CMD_BOOTEFI_HELLO is not set
rpi_3_defconfig # CONFIG_CMD_BOOTEFI_HELLO is not set
rpi_3_b_plus_defconfig # CONFIG_CMD_BOOTEFI_HELLO is not set
rpi_arm64_defconfig # CONFIG_CMD_BOOTEFI_HELLO is not set

Which configuration have you been testing?

Please, supply the .config and the related test log.

I just tested pinea64-lts_defconfig with CONFIG_CMD_BOOTEFI_HELLO=y and get

=> bootefi hello
Card did not respond to voltage select! : -110
Booting /MemoryMapped(0x0,0xbdfbe9b0,0xbdfc1b60)
Hello, world!
Running on UEFI 2.10
Firmware vendor: Das U-Boot
Firmware revision: 20250100
Have device tree
Load options: <none>
File path: <none>
Boot device: /MemoryMapped(0x0,0xbdfbe9b0,0xbdfc1b60)

So there seems to be no generic problem.

Best regards

Heinrich