[PATCH 1/2] efi_loader: Expose efi_reinstall_protocol_interface in efi_loader.h

Ilias Apalodimas ilias.apalodimas at linaro.org
Fri Dec 6 15:59:06 CET 2024


On Fri, 6 Dec 2024 at 14:27, Adriano Cordova <adrianox at gmail.com> wrote:
>
> Signed-off-by: Adriano Cordova <adriano.cordova at canonical.com>
> ---
>  include/efi_loader.h          | 5 +++++
>  lib/efi_loader/efi_boottime.c | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/include/efi_loader.h b/include/efi_loader.h
> index 9afbec35eb..0d858c1e12 100644
> --- a/include/efi_loader.h
> +++ b/include/efi_loader.h
> @@ -711,6 +711,11 @@ efi_status_t efi_search_protocol(const efi_handle_t handle,
>  efi_status_t efi_add_protocol(const efi_handle_t handle,
>                               const efi_guid_t *protocol,
>                               void *protocol_interface);
> +/* Reinstall a protocol on a handle */
> +efi_status_t EFIAPI efi_reinstall_protocol_interface(
> +                       efi_handle_t handle,
> +                       const efi_guid_t *protocol,
> +                       void *old_interface, void *new_interface);
>  /* Open protocol */
>  efi_status_t efi_protocol_open(struct efi_handler *handler,
>                                void **protocol_interface, void *agent_handle,
> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
> index 080e7f78ae..58716fa795 100644
> --- a/lib/efi_loader/efi_boottime.c
> +++ b/lib/efi_loader/efi_boottime.c
> @@ -3733,7 +3733,7 @@ out:
>   *
>   * Return: status code
>   */
> -static efi_status_t EFIAPI efi_reinstall_protocol_interface(
> +efi_status_t EFIAPI efi_reinstall_protocol_interface(
>                         efi_handle_t handle, const efi_guid_t *protocol,
>                         void *old_interface, void *new_interface)
>  {
> --
> 2.43.0
>

The change is fine, but as Heinrich said, please send a v2 explaining
why you need this. Otherwise one will remember in a year from now

Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>


More information about the U-Boot mailing list