[PATCH v1 1/2] gpio: add PMIC_GPIO Kconfig option

[Tom Rini]

On Fri, Dec 06, 2024 at 05:40:49PM +0200, Svyatoslav Ryhel wrote:

> Add more generic Kconfig option to be enabled by the PMIC drivers
> which do not have dedicated GPIO node and use same phandle to refer
> to both core driver and GPIO child.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95 at gmail.com>
> ---
>  drivers/gpio/Kconfig       | 8 ++++++++
>  drivers/gpio/gpio-uclass.c | 2 +-
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 92a8597420a..b7a3dd7b221 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -255,6 +255,7 @@ config MAX7320_GPIO
>  config MAX77663_GPIO
>  	bool "MAX77663 GPIO cell of PMIC driver"
>  	depends on DM_GPIO && DM_PMIC_MAX77663
> +	select PMIC_GPIO
>  	help
>  	  GPIO driver for MAX77663 PMIC from Maxim Semiconductor.
>  	  MAX77663 PMIC has 8 pins that can be configured as GPIOs
> @@ -474,6 +475,13 @@ config PIC32_GPIO
>  	help
>  	  Say yes here to support Microchip PIC32 GPIOs.
>  
> +config PMIC_GPIO
> +	bool "PMIC without exposed GPIO node"
> +	depends on DM_GPIO
> +	help
> +	  Choose this option if your PMIC does not have dedicated GPIO node
> +	  and phandle of the PMIC itself is used as a GPIO phandle.

We shouldn't prompt for this, and instead select it (like you do above)
when required. So please drop the prompt text and change the help to
star with "Select this option ..." thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20241206/d910fb74/attachment.sig>