[PATCH 3/3] cmd: ufetch: Show CPU architecture under "CPU"

Caleb Connolly caleb.connolly at linaro.org
Mon Dec 9 16:09:30 CET 2024


Thanks for the patch!

On 05/12/2024 19:35, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer" <j.ne at posteo.net>
> 
> When looking at ufetch output it isn't immediately obvious which CPU
> architecture the presented board has. This patch therefore adds the CPU
> architecture string (for example "powerpc") to the "CPU:" line.

It would be nice to have the proper fancy name, but this is an
improvement nonetheless.
> 
> Signed-off-by: J. Neuschäfer <j.ne at posteo.net>
> ---
>  cmd/ufetch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmd/ufetch.c b/cmd/ufetch.c
> index 7aed0b447bda104b837d37c6adcbb21b80237aba..0ee50bfb606aa2223072c63cd46b3a70ef5449fd 100644
> --- a/cmd/ufetch.c
> +++ b/cmd/ufetch.c
> @@ -188,7 +188,7 @@ static int do_ufetch(struct cmd_tbl *cmdtp, int flag, int argc,
>  				if (ofnode_name_eq(np, "cpu"))
>  					n_cpus++;
>  			}
> -			printf("CPU:" RESET " %d (1 in use)\n", n_cpus);
> +			printf("CPU: " RESET CONFIG_SYS_ARCH ", %d (1 in use)\n", n_cpus);

This will read like

CPU: arm 4 (1 in use)

which is a bit hard to parse at a glance. How about

CPU: arm [4 cores]

or some other separator between SYS_ARCH and the core count?

Kind regards,
>  			break;
>  		case MEMORY:
>  			for (int j = 0; j < CONFIG_NR_DRAM_BANKS && gd->bd->bi_dram[j].size; j++)
> 

-- 
// Caleb (they/them)



More information about the U-Boot mailing list