[PATCH v5 1/2] riscv: spacemit: bananapi_f3: initial support added

Huan Zhou pericycle.cc at gmail.com
Tue Dec 10 06:38:12 CET 2024


Hi,
First of all, Sorry for the previous private message.

On Tue, Dec 10, 2024 at 10:15:25AM +0800, Yixun Lan wrote:
> Hi Huan:
> 
> Please rebase this patch on top of most recent master branch
> as it fail to apply due to changes of arch/riscv/dts/Makefile
> 
> On 10:00 Mon 09 Dec     , Huan Zhou wrote:
> > From: Kongyang Liu <seashell11234455 at gmail.com>
> > 
> > Add basic support for SpacemiT's Banana Pi F3 board.
> > Update the k1.dtsi align with mainline.
> > Note that the device tree files follow the mainline Linux source[1].
> > 
> > [1]. https://patches.linaro.org/project/linux-serial/patch/20240730-k1-01-basic-dt-v5-8-98263aae83be@gentoo.org/
> suggest style: Link: https://.. [1]
got it.
> > 
> > Signed-off-by: Kongyang Liu <seashell11234455 at gmail.com>
> > Signed-off-by: Huan Zhou <pericycle.cc at gmail.com>
> > ---
> ..
> > diff --git a/include/configs/bananapi-f3.h b/include/configs/bananapi-f3.h
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..aecf69cd4cf8ddaea7dee57bf1a8ce8dc5db513d
> > --- /dev/null
> > +++ b/include/configs/bananapi-f3.h
> > @@ -0,0 +1,13 @@
> > +/* SPDX-License-Identifier: GPL-2.0-or-later */
> > +/*
> > + * Copyright (c) 2024, Kongyang Liu <seashell11234455 at gmail.com>
> > + *
> > + */
> > +
> > +#ifndef __CONFIG_H
> > +#define __CONFIG_H
> > +
> > +#define CFG_SYS_SDRAM_BASE         0x0
> > +#define CFG_SYS_NS16550_IER        0x40
> I'd suggest to keep the comment..
ok, should i send next version of patch btw?
> #define CFG_SYS_NS16550_IER        0x40 /* UART Unit Enable */
> > +
> > +#endif /* __CONFIG_H */
> > 
> > -- 
> > 2.39.5
> > 
> 
> -- 
> Yixun Lan (dlan)
> Gentoo Linux Developer
> GPG Key ID AABEFD55


More information about the U-Boot mailing list