[PATCH v4 09/25] efi_loader: Use the enum for memory type

[Simon Glass]

Hi Heinrich,

On Tue, 3 Dec 2024 at 08:53, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Heinrich,
>
> On Tue, 3 Dec 2024 at 07:38, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >
> > On 01.12.24 16:24, Simon Glass wrote:
> > > Rather than an integer, it is better to use the enum provided, when
> > > referring to an EFI memory-type. Update existing uses.
> > >
> > > Call the value 'mem_type' consistently. Fix up one instance of
> > > upper-case hex.
> > >
> > > Fix up the calls in struct efi_boot_services so that they use the same
> > > enum, adding the missing parameter names and enum efi_allocate_type.
> > >
> > > While we are here, rename the 'memory' parameter to 'memoryp' so that it
> > > is clear it is a return value.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> >
> > Simon, I have no clue why you keep ignoring reviews.
> > This is just annoying and won't lead to merging patches.
>
> I got your feedback on [1] and incorporated it in v2 onwards. Did you notice?
>
> >
> > NAK

It has been a week and I have not had any response on this. Does that
mean you are OK with the patch now?

Regards,
Simon