[PATCH v5 21/23] efi_loader: Drop comments about incorrect addresses
Simon Glass
sjg at chromium.org
Wed Dec 11 14:54:15 CET 2024
Now that these problems have been resolved, drop the comments.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
(no changes since v1)
lib/efi_loader/efi_acpi.c | 2 --
lib/efi_loader/efi_bootmgr.c | 3 ---
lib/efi_loader/efi_smbios.c | 6 +-----
3 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/lib/efi_loader/efi_acpi.c b/lib/efi_loader/efi_acpi.c
index ffb360d461b..67bd7f8ca24 100644
--- a/lib/efi_loader/efi_acpi.c
+++ b/lib/efi_loader/efi_acpi.c
@@ -28,14 +28,12 @@ efi_status_t efi_acpi_register(void)
/* Mark space used for tables */
start = ALIGN_DOWN(gd->arch.table_start, EFI_PAGE_MASK);
end = ALIGN(gd->arch.table_end, EFI_PAGE_MASK);
- /* TODO(sjg): This should use (ulong)map_sysmem(start, ...) */
ret = efi_add_memory_map(start, end - start, EFI_ACPI_RECLAIM_MEMORY);
if (ret != EFI_SUCCESS)
return ret;
if (gd->arch.table_start_high) {
start = ALIGN_DOWN(gd->arch.table_start_high, EFI_PAGE_MASK);
end = ALIGN(gd->arch.table_end_high, EFI_PAGE_MASK);
- /* TODO(sjg): This should use (ulong)map_sysmem(start, ...) */
ret = efi_add_memory_map(start, end - start,
EFI_ACPI_RECLAIM_MEMORY);
if (ret != EFI_SUCCESS)
diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c
index 30d4ce09e7e..9383adbd958 100644
--- a/lib/efi_loader/efi_bootmgr.c
+++ b/lib/efi_loader/efi_bootmgr.c
@@ -366,8 +366,6 @@ static efi_status_t prepare_loaded_image(u16 *label, ulong addr, ulong size,
* TODO: expose the ramdisk to OS.
* Need to pass the ramdisk information by the architecture-specific
* methods such as 'pmem' device-tree node.
- *
- * TODO(sjg): This should use (ulong)map_sysmem(addr)
*/
ret = efi_add_memory_map(addr, size, EFI_RESERVED_MEMORY_TYPE);
if (ret != EFI_SUCCESS) {
@@ -402,7 +400,6 @@ static efi_status_t efi_bootmgr_release_uridp(struct uridp_context *ctx)
/* cleanup for iso or img image */
if (ctx->ramdisk_blk_dev) {
- /* TODO(sjg): This should use (ulong)map_sysmem(...) */
ret = efi_add_memory_map(ctx->image_addr, ctx->image_size,
EFI_CONVENTIONAL_MEMORY);
if (ret != EFI_SUCCESS)
diff --git a/lib/efi_loader/efi_smbios.c b/lib/efi_loader/efi_smbios.c
index 02d4a5dd045..8d2ef6deb51 100644
--- a/lib/efi_loader/efi_smbios.c
+++ b/lib/efi_loader/efi_smbios.c
@@ -40,11 +40,7 @@ efi_status_t efi_smbios_register(void)
return EFI_NOT_FOUND;
}
- /*
- * Mark space used for tables/
- *
- * TODO(sjg): This should use (ulong)map_sysmem(addr, ...)
- */
+ /* Mark space used for tables */
ret = efi_add_memory_map(addr, TABLE_SIZE, EFI_RUNTIME_SERVICES_DATA);
if (ret)
return ret;
--
2.34.1
More information about the U-Boot
mailing list