[PATCH v1 11/12] video: panel: lq101r1sx01: remove unnecessary setup
Svyatoslav Ryhel
clamor95 at gmail.com
Thu Dec 12 11:21:18 CET 2024
Left-right split is enabled only by sending 0x1000 to
MIPI_DCS_SET_COLUMN_ADDRESS (0x2a) and does not require any other
manipulations. sharp_setup_symmetrical_split function is left as
a reference for possible even-odd split implementation or video
mode support where commands have to be sent to both links.
Signed-off-by: Svyatoslav Ryhel <clamor95 at gmail.com>
---
drivers/video/sharp-lq101r1sx01.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/video/sharp-lq101r1sx01.c b/drivers/video/sharp-lq101r1sx01.c
index 5d8453fd796..504122abda6 100644
--- a/drivers/video/sharp-lq101r1sx01.c
+++ b/drivers/video/sharp-lq101r1sx01.c
@@ -57,9 +57,10 @@ static int sharp_lq101r1sx01_write(struct mipi_dsi_device *dsi,
return 0;
}
-static int sharp_setup_symmetrical_split(struct mipi_dsi_device *left,
- struct mipi_dsi_device *right,
- struct display_timing *timing)
+static int __maybe_unused
+sharp_setup_symmetrical_split(struct mipi_dsi_device *left,
+ struct mipi_dsi_device *right,
+ struct display_timing *timing)
{
int ret;
@@ -104,9 +105,7 @@ static int sharp_lq101r1sx01_enable_backlight(struct udevice *dev)
return 0;
struct mipi_dsi_panel_plat *plat = dev_get_plat(dev);
- struct mipi_dsi_panel_plat *plat_sec = dev_get_plat(priv->panel_sec);
struct mipi_dsi_device *link1 = plat->device;
- struct mipi_dsi_device *link2 = plat_sec->device;
int ret;
ret = mipi_dsi_dcs_exit_sleep_mode(link1);
@@ -142,16 +141,17 @@ static int sharp_lq101r1sx01_enable_backlight(struct udevice *dev)
/*
* TODO: The device supports both left-right and even-odd split
* configurations, but this driver currently supports only the left-
- * right split. To support a different mode a mechanism needs to be
- * put in place to communicate the configuration back to the DSI host
- * controller.
+ * right split in command mode. To support a different mode a
+ * mechanism needs to be put in place to communicate the
+ * configuration back to the DSI host controller.
+ *
+ * Left-right split is enabled only by sending 0x1000 to
+ * MIPI_DCS_SET_COLUMN_ADDRESS (0x2a) and does not require any
+ * other manipulations. sharp_setup_symmetrical_split function is
+ * left as a reference for possible even-odd split implementation
+ * or video mode support where commands have to be sent to both
+ * links.
*/
- ret = sharp_setup_symmetrical_split(link1, link2, &default_timing);
- if (ret < 0) {
- log_debug("%s: failed to set up symmetrical split: %d\n",
- __func__, ret);
- return ret;
- }
ret = mipi_dsi_dcs_set_display_on(link1);
if (ret < 0) {
--
2.43.0
More information about the U-Boot
mailing list