[PATCH 1/5] board: sl28: fix linking with disabled watchdog

Heiko Thiery heiko.thiery at gmail.com
Fri Dec 13 12:07:39 CET 2024


Hi,

Am Fr., 13. Dez. 2024 um 11:23 Uhr schrieb Michael Walle <mwalle at kernel.org>:
>
> We don't have a reference to the driver used by
> uclass_get_device_by_driver() in stop_recovery_watchdog(). Fix it by not
> calling that function if the watchdog driver isn't enabled.
>
> Signed-off-by: Michael Walle <mwalle at kernel.org>

Reviewed-by: Heiko Thiery <heiko.thiery at gmail.com>

> ---
>  board/kontron/sl28/sl28.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/board/kontron/sl28/sl28.c b/board/kontron/sl28/sl28.c
> index adfec8ba237..0baf5c63f18 100644
> --- a/board/kontron/sl28/sl28.c
> +++ b/board/kontron/sl28/sl28.c
> @@ -156,7 +156,8 @@ int fsl_board_late_init(void)
>          * If the watchdog isn't enabled at reset (which is a configuration
>          * option) disabling it doesn't hurt either.
>          */
> -       if (!IS_ENABLED(CONFIG_WATCHDOG_AUTOSTART))
> +       if (IS_ENABLED(CONFIG_WDT_SL28CPLD) &&
> +           !IS_ENABLED(CONFIG_WATCHDOG_AUTOSTART))
>                 stop_recovery_watchdog();
>
>         return 0;
> --
> 2.39.5
>


More information about the U-Boot mailing list