[PATCH] imx: hab: fix srktool -c usage by removing spaces

Christoph Fritz chf.fritz at googlemail.com
Mon Dec 16 09:27:17 CET 2024


Hi Fabio

> On Sun, Dec 15, 2024 at 2:04 PM Christoph Fritz
> <chf.fritz at googlemail.com> wrote:
> 
> > +  $ CERTS="SRK1_sha256_2048_65537_v3_ca_crt.pem"
> > +  $ CERTS="$CERTS,SRK2_sha256_2048_65537_v3_ca_crt.pem"
> > +  $ CERTS="$CERTS,SRK3_sha256_2048_65537_v3_ca_crt.pem"
> > +  $ CERTS="$CERTS,SRK4_sha256_2048_65537_v3_ca_crt.pem"
> > +
> >    $ ../linux64/bin/srktool -h 4 -t SRK_1_2_3_4_table.bin -e \
> > -       SRK_1_2_3_4_fuse.bin -d sha256 -c \
> > -       SRK1_sha256_2048_65537_v3_ca_crt.pem,\
> > -       SRK2_sha256_2048_65537_v3_ca_crt.pem,\
> > -       SRK3_sha256_2048_65537_v3_ca_crt.pem,\
> > -       SRK4_sha256_2048_65537_v3_ca_crt.pem
> > +       SRK_1_2_3_4_fuse.bin -d sha256 -c "$CERTS"
> 
> What do you think about simplifying like this instead?
> 
> --- a/doc/imx/habv4/introduction_habv4.txt
> +++ b/doc/imx/habv4/introduction_habv4.txt
> @@ -244,12 +244,10 @@ Table Hash.
> 
>  - Generating SRK Table and SRK Hash in Linux 64-bit machines:
> 
> +  $ CA_CRT="sha256_2048_65537_v3_ca_crt.pem"
>    $ ../linux64/bin/srktool -h 4 -t SRK_1_2_3_4_table.bin -e \
>         SRK_1_2_3_4_fuse.bin -d sha256 -c \
> -       SRK1_sha256_2048_65537_v3_ca_crt.pem,\
> -       SRK2_sha256_2048_65537_v3_ca_crt.pem,\
> -       SRK3_sha256_2048_65537_v3_ca_crt.pem,\
> -       SRK4_sha256_2048_65537_v3_ca_crt.pem
> +       SRK1_"$CA_CRT",SRK2_"$CA_CRT",SRK3_"$CA_CRT",SRK4_"$CA_CRT"

thanks, looks great. Do you want me to adapt the patch and resend?

 -- Christoph


More information about the U-Boot mailing list