[PATCH 0/5] sandbox: repair compile and run-time for OF_EMBED case

[Evgeny Bachinin]

Hello, Simon.


On Fri, Dec 06, 2024 at 12:19:42PM -0700, Simon Glass wrote:
> Hi Evgeny,
> 
> On Mon, 2 Dec 2024 at 06:46, Evgeny Bachinin
> <EABachinin at salutedevices.com> wrote:
> >
> > This patch-set repairs ability to use sandbox with CONFIG_OF_EMBED=y.
> >
> > For now, to use OF_EMBED, the following must be done
> > 1) sandbox64_defconfig should have:
> >   ```
> >   -CONFIG_OF_LIVE=y
> >   +CONFIG_OF_EMBED=y
> >   ```
> >
> > 2) On sandbox when CONFIG_OF_EMBED=y, the u-boot process can't start
> > due to:
> >   ```
> >   Bloblist at b000 not found (err=-2)
> >   initcall failed at call 000000000011829c (err=-2: No such file or \
> >       directory)
> >   ### ERROR ### Please RESET the board ###
> >   ```
> >   So, it is natural desire to disable CONFIG_BLOBLIST just to test
> > sandbox with OF_EMBED=y (disable it one way or another):
> >   ```
> >     config SANDBOX
> >   -     select BLOBLIST
> >   +     select BLOBLIST if SOME_NON_EXISTING_OPTION
> >   ```
> >
> > 3) As a result, having such changes (CONFIG_OF_EMBED=y &&
> > CONFIG_BLOBLIST=n) leads to the link & run-time errors, being fixed
> > by this patch series.
> >
> > Signed-off-by: Evgeny Bachinin <EABachinin at salutedevices.com>
> > ---
> > Tested:
> > * locally with aforementioned options applied
> > * CI - https://github.com/u-boot/u-boot/pull/704
> >   * No regression
> >
> > ---
> > Evgeny Bachinin (5):
> >       sandbox: fix bloblist_finish() linker error if BLOBLIST=n
> >       test: sandbox: fix invalid_use_of_IF_ENABLED_INT if BLOBLIST=n
> >       test: sandbox: fix link error with do_ut_bloblist if BLOBLIST=n
> >       test: sandbox: fix link error with do_ut_bootm if BLOBLIST=n
> >       sandbox: set retval early in board_fdt_blob_setup()
> >
> >  arch/sandbox/cpu/cpu.c |  2 +-
> >  include/bloblist.h     |  7 +++++++
> >  test/cmd_ut.c          |  2 ++
> >  test/lib/kconfig.c     | 10 ++++++----
> >  4 files changed, 16 insertions(+), 5 deletions(-)
> > ---
> > base-commit: 3073246d1be682071d8b3d07d06c2484907aed60
> > change-id: 20241120-sandbox_repair_of_embed-2188465eb22b
> >
> > Best regards,
> > --
> > Evgeny Bachinin <EABachinin at salutedevices.com>
> >
> 
> Thanks for looking at this.
> 
> You could add a test for ~OF_EMBED in
> test/py/tests/test_sandbox_opts.py if you want to keep this working in
> future.

I did not know about this. Thank you, will do.

-- 
Best Regards,
Evgeny Bachinin