[PATCH v2 1/1] rtc: CONFIGS_RTC_PL031 must depend on CONFIGS_DM_RTC

Linus Walleij linus.walleij at linaro.org
Tue Dec 17 15:03:57 CET 2024


On Thu, Dec 5, 2024 at 9:36 PM Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:

> Building qemu_arm64_defconfig with CONFIGS_DM_RTC=n and CONFIGS_RTC_PL031=y
> leads to a build failure.
>
> Adjust the vexpress64 configuration to avoid circular dependency.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
> v2:
>     Adjust the vexpress64 configuration to avoid circular dependency.

> +       imply DM_RTC
>         imply RTC_PL031
> -       select DM_RTC if RTC_PL031

Should it not be:
imply RTC_PL031 if DM_RTC

(The dependency in the driver will fix it I guess.)

The way we are using imply in U-Boot is a bit worrisome
but I'm no expert. It may work better in our case because we
never have an option be "m" (module) as in Linux... This
works for sure.

Yours,
Linus Walleij


More information about the U-Boot mailing list