[PATCH v2 1/1] gitlab: Add a StarFive VisionFive2 to the sjg lab

[Simon Glass]

Hi Heinrich,

On Mon, 16 Dec 2024 at 17:23, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> Am 17. Dezember 2024 00:38:53 MEZ schrieb Simon Glass <sjg at chromium.org>:
> >I have one of these boards loaded with Ubuntu 24.10 (64-bit). Add an
> >entry for it so that it can be used for testing.
> >
> >Signed-off-by: Simon Glass <sjg at chromium.org>
>
> .gitlab-ci.yml supports an include statement.
> Maybe it would make sense to move the lab definitions for lab_dfn into an include.
>
> Such a file could be conditionally included:
>
> include:
>   - local: 'lab_dfn.yml'
>     rules:
>       - if: '$LAB == "dfn"'
>
> Cf. https://docs.gitlab.com/ee/ci/yaml/index.html
>

Yes, it would be a bit cleaner to have an include file, but it should
not be conditional. Tom is missing a patch.

>
> For the current patch
>
> Acked-By: Heinrich Schuchardt <xypron.glpk at gmx.de>
>

Thanks

>
>
> >---
> >
> >Changes in v2:
> >- Rename the board to vf2
> >- Add a comment about what the board is
> >
> > .gitlab-ci.yml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> >diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> >index ffcf8532944..a17c1b0a366 100644
> >--- a/.gitlab-ci.yml
> >+++ b/.gitlab-ci.yml
> >@@ -696,3 +696,9 @@ rpi:
> >   variables:
> >     ROLE: rpi
> >   <<: *lab_dfn
> >+
> >+# StarFive VisionFive 2
> >+vf2:
> >+  variables:
> >+    ROLE: vf2
> >+  <<: *lab_dfn
>

Regards,
Simon